Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property tests #45

Closed
wants to merge 2 commits into from
Closed

Conversation

waisbrot
Copy link

I don't know that this actually solves #4, but I wanted to try learning property tests and this is what I ended up with.

Overall, I liked it. I can run the tests with rebar3:

rebar3 proper

it accepts a --cover flag to collect coverage data. Running PropEr tests and understanding failures is pretty easy.

The part I found difficult was generating tests that were not trivial and didn't involve re-inventing the iso8601 library in the test code. I'm not sure how well I did there.

- Add the rebar3_proper plugin
- Add proper as a test dependency
- Add several property tests
@oubiwann
Copy link
Member

I haven’t looked at the Travis error for this, but if you can get that fixed (and make sure these new tests are run by Travis), I’d be willing to merge your change.

@oubiwann
Copy link
Member

Hrm, all are failing now; the Travis errors give no info. You might have to DEBUG=1 ...

@waisbrot
Copy link
Author

waisbrot commented Dec 5, 2017

Sorry I haven't been touching this. The problem is that OTP < 18 can't run PropEr tests (at least, not using the Rebar3 plugin and code that I supply here). Getting Travis to do the right thing is usually a lengthy process of trial and error for me, but I do plan on coming back to this when I'm less busy elsewhere.

@oubiwann
Copy link
Member

oubiwann commented Dec 8, 2020

heads up on this -- we're going to follow rebar3's approach, and only actively test Erlang 19+ ...

@waisbrot waisbrot closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants