Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add a warning message when Ersilia found running in a Python env less than 3.8 #1501 #1517

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Damisicode
Copy link

@Damisicode Damisicode commented Jan 18, 2025

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description
Added a check to the create create_cli module to check if the user's version is less than 3.8 and returns an error message in red.

Status

  • Added the check to the create_cli.py
  • updated the messages.py for the VersionNotSupported class which returns the error message and exits the program

Related to #1501

@DhanshreeA
Copy link
Member

@Damisicode could you please update the results you saw from testing your change? :) Thanks a bunch. Otherwise the PR looks good!

@Damisicode
Copy link
Author

While testing using an old python conda environment, I got this error while it's installing the required packages but it works well using a valid python conda environment.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants