Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace strip-ansi with native stripVTControlCharacters #122

Open
Namchee opened this issue Oct 2, 2024 · 7 comments
Open

Replace strip-ansi with native stripVTControlCharacters #122

Namchee opened this issue Oct 2, 2024 · 7 comments
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each

Comments

@Namchee
Copy link

Namchee commented Oct 2, 2024

Overview

stripVTControlCharacters from Node core utilities provide the same functionality.

Do note that this utility function requires Node 16.11.0 or higher.

@benmccann
Copy link

Some big ones:

  • enquirer
  • eslint
  • string-width
  • wrap-ansi

The latter two are by the same author as strip-ansi, so TBD if they'd want to swap. Worth a shot though

@pralkarz
Copy link

pralkarz commented Oct 2, 2024

Also:

  • stylelint
  • lerna
  • ava
  • astro
  • some packages in the jest monorepo

@43081j
Copy link
Collaborator

43081j commented Oct 4, 2024

The latter two are by the same author as strip-ansi, so TBD if they'd want to swap. Worth a shot though

Maybe we can go one level higher and migrate away from the packages consuming it?

@Namchee
Copy link
Author

Namchee commented Oct 4, 2024

Would like to include:

  • cucumber
  • gatsby
  • cspell

Done:

In Progress:

@Namchee
Copy link
Author

Namchee commented Oct 4, 2024

As for lerna, I think it's better for us to do it on nx instead since the stewardship has passed from Lerna

stianjensen added a commit to stianjensen/metro that referenced this issue Oct 6, 2024
stripVTControlCharacters from Node core utilities provide the same
functionality, and is available since Node 16.11. This project currently
requires minimum Node 18.18.

See es-tooling/ecosystem-cleanup#122 for
similar efforts to replace this dependency in other projects.
@benmccann
Copy link

I noticed today that enquirer says it has only a single dependency. It's not true, but would be if this migration were done

@Namchee
Copy link
Author

Namchee commented Oct 15, 2024

I don't think we can remove strip-ansi from enquirer as enquirer sets the engine to >=8.6

facebook-github-bot pushed a commit to facebook/metro that referenced this issue Oct 16, 2024
Summary:
stripVTControlCharacters from Node core utilities provide the same functionality, and is available since Node 16.11. This project currently requires minimum Node 18.18.

See es-tooling/ecosystem-cleanup#122 for similar efforts to replace this dependency in other projects.

Pull Request resolved: #1366

Reviewed By: huntie

Differential Revision: D63957530

Pulled By: robhogan

fbshipit-source-id: 0b6b3a7e7b076b1ff664b717ce77e1dcc203b0c7
@Fuzzyma Fuzzyma added the umbrella issue This issue contains a list of dependents of a package and tracks the progress in each label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each
Projects
None yet
Development

No branches or pull requests

5 participants