Replace strip-ansi with native module #1366
Closed
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripVTControlCharacters from Node core utilities provide the same functionality, and is available since Node 16.11. This project currently requires minimum Node 18.18. See es-tooling/ecosystem-cleanup#122 for similar efforts to replace this dependency in other projects.
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for this @stianjensen! Always nice to remove a dependency. |
robhogan
approved these changes
Oct 6, 2024
|
I'm not so familiar with flow, so I'm not quite sure where the typings for util that are failing now come from. |
|
They're mostly compiled in to Flow, and can fall behind for newer APIs. You can locally suppress with |
|
I also managed to get type support merged into flow, but ignoring the types for now probably also works: I'll leave it up to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripVTControlCharacters from Node core utilities provide the same functionality, and is available since Node 16.11. This project currently requires minimum Node 18.18.
See es-tooling/ecosystem-cleanup#122 for similar efforts to replace this dependency in other projects.