Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Manifest.toml to .gitignore #52

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Feb 11, 2025

This PR aims to add Manifest.toml to .gitignore. This will allow users to add the packages without having to worry about changes in Manifest.toml that shows up on PR.

@davidamarquis
Copy link
Collaborator

davidamarquis commented Feb 12, 2025

I appreciate you want to improve the workflow and I like the sound of this change. Compared with a normal pull request, syncing git workflow changes across multiple people involves a bit of extra work.

If we're going to do this change then there's a few more things you need to do, I think:

  1. find the git command for stopping tracking a file that's already tracked and add it to the PR description above
  2. communicate this PR on the Slack to make sure everyone who makes PRs knows that when they update their local working directory from the remote dev branch that they need to run the command in step 1)
  3. remove the Manifest.toml file from CT in this PR

If a person who makes PRs doesn't do 2) then Manifest.toml is just going to be slipped back in on their next PR.

There may be other steps I haven't thought of. Its worth taking the time to think about because its an opportunity to learn more about git.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Feb 12, 2025

Thank you for your positive reaction and your feedback! That is much appreciated!

@esabo esabo merged commit fe3650c into esabo:dev Feb 27, 2025
1 check failed
@Fe-r-oz Fe-r-oz deleted the fa/add-Manifest-to-gitignore branch February 28, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants