Merge pull request #1 from esender/eslint

introduce eslint

.codeclimate.yml

@@ -4,22 +4,13 @@ engines:
     enabled: true
     config:
       languages:
-      - ruby
       - javascript
-      - python
-      - php
   eslint:
     enabled: true
   fixme:
     enabled: true
 ratings:
   paths:
-  - "**.inc"
   - "**.js"
-  - "**.jsx"
-  - "**.module"
-  - "**.php"
-  - "**.py"
-  - "**.rb"
 exclude_paths:
 - test/

.eslintrc

@@ -1,12 +1,11 @@
+parserOptions:
+  sourceType: module
+
 ecmaFeatures:
   modules: true
-  jsx: true
 
 env:
-  amd: true
-  browser: true
   es6: true
-  jquery: true
   node: true
 
 # http://eslint.org/docs/rules/
@@ -57,7 +56,6 @@ rules:
   no-case-declarations: 2
   no-div-regex: 2
   no-else-return: 0
-  no-empty-label: 2
   no-empty-pattern: 2
   no-eq-null: 2
   no-eval: 2

README.md

@@ -23,7 +23,7 @@ export default bushido.createPaths([
     addResource('content')
   ]),
   addResource('pages')
-])
+]);
 ```
 
 ```javascript
@@ -34,6 +34,5 @@ paths.pages(4).path // => '/pages/4'
 
 paths.books.pages.paragraphs.path // => '/books/pages/paragraphs'
 paths.books(3).pages(5).paragraphs(7).path // => '/books/3/pages/5/paragraphs/7'
-paths.books(6).pages.paragrahps.path // => '/books/6/pages/paragraphs'
+paths.books(6).pages.paragraphs.path // => '/books/6/pages/paragraphs'
 ```
-

package.json

@@ -4,6 +4,7 @@
   "description": "",
   "main": "./src/index.js",
   "scripts": {
+    "lint": "eslint --ext .js ./src ./test",
     "test": "mocha -c --require babel-register ./test/**.js",
     "test_watch": "mocha -w -c --require babel-register ./test/**.js"
   },
@@ -14,6 +15,7 @@
     "babel-preset-stage-0": "^6.16.0",
     "babel-register": "^6.16.3",
     "chai": "^3.5.0",
+    "eslint": "^3.8.1",
     "mocha": "^3.1.2"
   }
 }

src/add_resource.js

@@ -1,34 +1,31 @@
-function addResource(resourceName, subResources) {
-  function carredResource (parentPath = '') {
-    let path = `${parentPath}/${resourceName}`;
+function addResource(resourceName, subResources = []) {
+  function carriedResource(parentPath = '') {
+    const path = `${parentPath}/${resourceName}`;
 
     function resource(id) {
-      let paths = {};
+      const paths = {};
 
       paths.path = `${path}/${id}`;
 
-      if(subResources) {
-        subResources.forEach( resource => {
-          paths[resource.resourceName] = resource(paths.path);
-        });
-      }
+      subResources.forEach((subResource) => {
+        paths[subResource.resourceName] = subResource(paths.path);
+      });
 
       return paths;
     }
 
     resource.path = path;
 
-    if (subResources) {
-      subResources.forEach( subResource => {
-        resource[subResource.resourceName] = subResource(path);
-      });
-    }
+    subResources.forEach((subResource) => {
+      resource[subResource.resourceName] = subResource(path);
+    });
 
     return resource;
   }
 
-  carredResource.resourceName = resourceName;
-  return carredResource;
+  carriedResource.resourceName = resourceName;
+
+  return carriedResource;
 }
 
-export default addResource;
+export default addResource;

src/index.js

@@ -1,11 +1,10 @@
 import addResource from './add_resource';
 
 class Bushido {
-  constructor() {}
-
   createPaths(resources) {
-    let paths = {};
-    resources.forEach( resource => {
+    const paths = {};
+
+    resources.forEach((resource) => {
       paths[resource.resourceName] = resource();
     });
 

test/add_resource_spec.js

@@ -1,7 +1,8 @@
-import addResource from '../src/add_resource';
 import { expect } from 'chai';
+import { beforeEach, describe, it } from 'mocha';
+import addResource from '../src/add_resource';
 
-describe('addResource', function(){
+describe('addResource', () => {
   describe('without subResources', () => {
     let carredResource;
 
@@ -19,7 +20,7 @@ describe('addResource', function(){
 
     describe('set parent resource', () => {
       let resource;
-      
+
       beforeEach(() => {
         resource = carredResource();
       });

test/index_spec.js

@@ -1,11 +1,12 @@
-import Bushido, { addResource } from '../src/index';
 import { expect } from 'chai';
+import { beforeEach, describe, it } from 'mocha';
+import Bushido, { addResource } from '../src/index';
 
-describe('Bushido', function(){
+describe('Bushido', () => {
   let helper;
 
   beforeEach(() => {
-    let bushido = new Bushido();
+    const bushido = new Bushido();
     helper = bushido.createPaths([
       addResource('books', [
         addResource('pages', [