Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predefined metrics #41

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix predefined metrics #41

merged 1 commit into from
Dec 18, 2024

Conversation

NelsonVides
Copy link
Contributor

@NelsonVides NelsonVides commented Dec 18, 2024

When load-testing TLS, I found that the predefined connection metrics are missing in amoc_arsenal. To fix this, add the metrics to app.config in amoc-arsenal-xmpp:

   {amoc_arsenal,
    [{predefined_metrics, [{times, connection},
                           {counters, connections},
                           {counters, connection_retries},
                           {counters, connection_failures}]}
    ]}

Also, fix the calls to application:get_application(?MODULE) in amoc-arsenal:

{ok, App} = application:get_application(?MODULE)

Verify in a load test, that the metrics are working.

@NelsonVides NelsonVides force-pushed the fix_predefined_metrics branch from e0c6eaf to 4b1547f Compare December 18, 2024 12:23
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit dbc84c9 into master Dec 18, 2024
7 checks passed
@NelsonVides NelsonVides deleted the fix_predefined_metrics branch December 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants