Many changes to the lhttpc client #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver. Now it supports conections without using a pool. It is possible to define clients and use them to establish connections. All the code from this commit was done by me and Diana Corbacho.
…function. Before one pool called lhttpc_manager was created during initialzation. With the new redesign this is not necessary.
Before it used to crash due to a call to parse_url.
…nection. It was not able to reconect once the server replied with a connection close header. Now it reconnects to the same host specified when the user starts the client using lhttp:connect_client() function.
Made several tests fail and other clients reply with the new format.
…ady closed). Fix one test case.
Test cases that do not pass at the moment are also commented.
…iguration * upload_window is not used any more, the gen_server synchronous call regulate the flow * pool options are a grouped argument in connect call
Also remove some lines of old commented code.
Still migth be necessary to improve the specs.
…eaders and stores them in the State. Still cookies need to be added to following request headers.
Still need to: - Add option for using cookies or not - Handle the path attribute on the cookie line. - Handle the expire time of the cookies. - Rewrite cookies with same name, not add them.
…path to include cookie when creating request.
Cookies are automatically deleted when they expire or return "delete" as their value.
… one the client is connected. Before it was possible to send requests with URL different to the one to which the client is connected, and the host and port were ignored (used the ones connected to). Now it checks wheter they are the same or gives an error otherwise.
There were calls to erlang:timestamp(), which does not exist.
Alexej needs it tonight, we had no time to fix the test... tomorrow will do amend.
* Remove duplicated specs. * Make the docs to include the type specs defined in .hrl files. * Change the documentation to reflect all the changes that were lately done to the library.
Now we are using Rebar to build.
|
As it is, this pull request is too wide for a proper review. Could you please split it in few, separate, pull requests? |
|
Hi Roberto. I know it is too big for a single pull request, it is more a merge from a development branch. The development was done in my own fork, and we were using pull requests and code reviews. You can see it on https://github.com/Lastres/lhttpc and take a look at the smaller pull requests. cheers, /Ramón. |
g-andrade
pushed a commit
to g-andrade/lhttpc
that referenced
this pull request
Nov 26, 2014
DynamoDB client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes all the changes that we have done to the client during the last months. I rebased against the master and should be ready to merge.
Before merging, it could be a good idea to tag the current version, as it is suggested in #30