Fix tests starting and stopping apps #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ok = lhttpc:start(). | ||
|
|
||
| stop_app(_) -> | ||
| AppsToStart = [asn1, public_key, ssl], |
There was a problem hiding this comment.
Isn't crypto required as well?
There was a problem hiding this comment.
crypto is started by rebar. Should I bother with something like ensure_started that's backward compatible?
|
Could you rebase this on the latest master? Not a real issue, but there's a duplicate Travis CI related commit. |
|
Can this be merged so that other pull requests can be looked at? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.