Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix PrivateIdentifier names with a # #921

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Jan 14, 2025

BREAKING CHANGE: when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.

fix #910 fix #911

Copy link

graphite-app bot commented Jan 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Status: Merge Queue - adds this PR to the back of the merge queue
  • Status: Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

BREAKING CHANGE: when using patterns to match against PrivateIdentifiers, their names are now
prefixed with a #.

fix #910 fix #911
@RebeccaStevens RebeccaStevens force-pushed the private-identifier-name branch from 234261e to f5acf36 Compare January 14, 2025 03:24
@RebeccaStevens RebeccaStevens added the Breaking Change This change will require a new major release. label Jan 14, 2025
@RebeccaStevens RebeccaStevens merged commit 8aacc39 into main Jan 14, 2025
14 checks passed
@RebeccaStevens RebeccaStevens deleted the private-identifier-name branch January 14, 2025 03:32
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
## [7.3.1](v7.3.0...v7.3.1) (2025-01-14)

### Bug Fixes

* prefix PrivateIdentifier names with a # ([#921](#921)) ([8aacc39](8aacc39))
Copy link

🎉 This PR is included in version 7.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Jan 14, 2025
RebeccaStevens added a commit that referenced this pull request Jan 14, 2025
BREAKING CHANGE: when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.

fix #910 fix #911
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
# [8.0.0](v7.3.0...v8.0.0) (2025-01-14)

### Bug Fixes

* prefix PrivateIdentifier names with a # ([#921](#921)) ([09b6474](09b6474)), closes [#910](#910) [#911](#911)

### BREAKING CHANGES

* when using patterns to match against PrivateIdentifiers, their names are now prefixed with a #.
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 14, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 15, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 15, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 15, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 15, 2025
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change will require a new major release. Status: Released It's now live.
Projects
None yet
1 participant