feat: Add support for media conditions in require-baseline rule #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
reviewed
Feb 17, 2025
| continue; | ||
| } | ||
|
|
||
| const conditionLevel = mediaConditions.get(child.name); |
There was a problem hiding this comment.
conditionLevel can be undefined if someone is using an unknown media condition. In that case, we should just exit early because no-invalid-at-rules should catch it.
There was a problem hiding this comment.
Good point! I've fixed it.
Add check for invalid at-rules
nzakas
reviewed
Feb 18, 2025
| @@ -556,6 +556,11 @@ export default { | |||
| node, | |||
| ) { | |||
| for (const child of node.children) { | |||
| // ignore unknown media conditions - no-invalid-at-rules already catches this | |||
There was a problem hiding this comment.
Can you also a add a test that has an invalid media condition to verify that it's ignored?
There was a problem hiding this comment.
I've added.
test: ignore unknown media conditions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request adds support for media conditions in the
require-baselinerule.What changes did you make? (Give an overview)
@mediaqueries.baseline-data.jsto include media conditions.Related Issues
fixes #48
Is there anything you'd like reviewers to focus on?