Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add package manager install checks #59

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

MikeMcC399
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Current CI checks do not include checking that the packaged version of the repo can be installed. This has allowed release of versions with installation regressions.

This PR adds a new workflow ci-build-all-pm.yml that fills the gap of checking the ability to install.

What changes did you make? (Give an overview)

A tarball is created from the repo package source using npm pack.

The tarball eslint-css-<version>.tgz is then used to install with each of the package manager instructions listed in the README > Installation section

npm install @eslint/css -D
yarn add @eslint/css -D
pnpm install @eslint/css -D
bun install @eslint/css -D

For Yarn, both Yarn v1 Classic and Yarn Modern are tested.

Related Issues

The following issues are related:

Due to these issues the corresponding tests for Yarn v1 Classic and pnpm are disabled.

Is there anything you'd like reviewers to focus on?

The outcome of the above two issues will determine whether the disabled tests can be enabled.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 21, 2025 11:23
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems super helpful, thank you.

@nzakas nzakas merged commit a9692b0 into eslint:main Feb 21, 2025
22 checks passed
@MikeMcC399
Copy link
Contributor Author

@nzakas

LGTM. This seems super helpful, thank you.

You're welcome! 🙂

Once the issues with the two failing package managers are resolved, the two disabling lines in the workflow can be removed so that all package managers are then tested.

@MikeMcC399 MikeMcC399 deleted the add/check-install branch February 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants