Add xtal frequency configuration #3054
Open
+59
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
xtasl
branch
4 times, most recently
from
05d97f9 to
f9ba7a0
Compare
bugadani
changed the title
MabezDev
reviewed
Jan 31, 2025
| ( | ||
| "xtal-frequency", | ||
| "The frequency of the crystal oscillator, in MHz. Set to `auto` to automatically detect the frequency. `auto` may not be able to identify the clock frequency in some cases. Also, configuring a specific frequency may increase performance slightly.", | ||
| Value::String(match device_name { |
There was a problem hiding this comment.
Are we going to run into issues if someone wants to set this config but also support multiple different chips in the same project?
There was a problem hiding this comment.
We won't, but they will
There was a problem hiding this comment.
I guess #3020 will support this scenario better
bjoernQ
reviewed
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ESP_HAL_CONFIG_XTAL_FREQUENCY- although only 32 and C2 have meaningful configurability. THe point of this PR is to allow const-propagatingxtal_freqwherever possible, mostly affectingesp_hal::time::now()and indirectly embassy-time.We could probably double-check in
Clocks::initthat the configured frequency matches what we measure, I don't know how badly we would want that, though.Running a modified
embassy_executor_benchmarkon the S2 (no time queue tasks, Task1 reading current time in every loop):now()black_box(now())