Add virtual beginMulticast(...) stub to UDP class #8969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It seems that (at least) the Arduino core and the ESP32 core both has the base
beginMulticast
virtual definition in the baseUDP
class:In order to be compatible with libraries like arduino-libraries/ArduinoMDNS, I've added the same base virtual function at
UDP
level here too.With these changes, the above library works on a ESP8266 like a charm.
I'm not sure if the different already existing signature of the
WiFiUDP::beginMulticast
should be left here or not. To be backward compatible, I've added both signatures, but not sure if the one with the different signature should be tagged as deprecated or not.Thanks!
L