Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266WebServer - free _currentArgs after request has been handled #9077

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

everslick
Copy link
Contributor

This can reduce permanent RAM consumption significantly, if the last request had lots of arguments, but it assumes, that we do not need the arguments after we have handled a request.

…ver.

This can reduce permanent RAM consumption significantly, if the last request had lots of arguments, but it assumes, that we do not need the arguments after we have handled a request.
Copy link
Collaborator

@mcspr mcspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair assumption, don't see any examples handling args after the request.

@mcspr mcspr changed the title Free memory for _currentArgs after request has been handled (WebServer). ESP8266WebServer - free _currentArgs after request has been handled Feb 9, 2024
@d-a-v d-a-v merged commit 9217458 into esp8266:master Feb 11, 2024
28 checks passed
@everslick everslick deleted the patch-3 branch February 11, 2024 18:11
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
…ver. (esp8266#9077)

This can reduce permanent RAM consumption significantly, if the last request had lots of arguments, but it assumes, that we do not need the arguments after we have handled a request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants