-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add documentation for LD2413 mmWave sensor #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
WalkthroughA new documentation file has been introduced for the LD2413 millimeter wave distance sensor within the ESPHome ecosystem. This file details the sensor’s features, provides pinout tables for its connectors, and offers a sample YAML configuration for integration via UART. The documentation also explains required parameters, references standard sensor configuration options, and links to related ESPHome resources. Changes
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
components/sensor/ld2413.rst (1)
25-28
: Suggest clearer table header
The column header "Illustrate" in the Pinout tables may confuse readers. Consider renaming it to something more descriptive, e.g., "Voltage Range" or "Signal Voltage".🧰 Tools
🪛 GitHub Check: build
[failure] 25-25:
Directive 'list-table' must be indented with 4 spaces, not 3. See components/sensor/ld2413.rst:25
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
components/sensor/images/ld2413-front-back.png
is excluded by!**/*.png
images/ld2413.png
is excluded by!**/*.png
📒 Files selected for processing (1)
components/sensor/ld2413.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
components/sensor/ld2413.rst
🪛 GitHub Check: build
components/sensor/ld2413.rst
[failure] 57-57:
Directive 'list-table' must be indented with 4 spaces, not 3. See components/sensor/ld2413.rst:57
[failure] 25-25:
Directive 'list-table' must be indented with 4 spaces, not 3. See components/sensor/ld2413.rst:25
[failure] 16-16:
Directive 'figure' is not followed by an empty line. Please insert an empty line after components/sensor/ld2413.rst:16
[failure] 17-17:
File contains tab character. Please convert tabs to spaces.
🪛 GitHub Actions: Lint
components/sensor/ld2413.rst
[error] 17-17: File contains tab character. Please convert tabs to spaces.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
♻️ Duplicate comments (1)
components/sensor/ld2413.rst (1)
14-17
:⚠️ Potential issueAdd blank line after figure directive and remove tab
RST requires an empty line between directive options and subsequent content. Also remove the stray tab on line 17.- :width: 50.0% - + :width: 50.0% +🧰 Tools
🪛 GitHub Check: build
[failure] 16-16:
Directive 'figure' is not followed by an empty line. Please insert an empty line after components/sensor/ld2413.rst:16
[failure] 17-17:
File contains tab character. Please convert tabs to spaces.🪛 GitHub Actions: Lint
[error] 17-17: File contains tab character. Please convert tabs to spaces.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/sensor/ld2413.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
components/sensor/ld2413.rst
🪛 GitHub Check: build
components/sensor/ld2413.rst
[failure] 54-54:
Directive 'list-table' is not followed by an empty line. Please insert an empty line after components/sensor/ld2413.rst:54
[failure] 23-23:
Directive 'list-table' is not followed by an empty line. Please insert an empty line after components/sensor/ld2413.rst:23
[failure] 16-16:
Directive 'figure' is not followed by an empty line. Please insert an empty line after components/sensor/ld2413.rst:16
[failure] 17-17:
File contains tab character. Please convert tabs to spaces.
🪛 GitHub Actions: Lint
components/sensor/ld2413.rst
[error] 17-17: File contains tab character. Please convert tabs to spaces.
🔇 Additional comments (1)
components/sensor/ld2413.rst (1)
4-6
: Verify SEO image path
The SEO block referencesld2413.png
, but the actual product image file isimages/ld2413-front-back.png
. Please confirm thatld2413.png
exists or update the path to the correct image file.
Description:
This PR adds documentation for the new LD2413 mmWave distance sensor.
The HLK-LD2413 is a compact 24GHz radar sensor designed for high-precision, non-contact measurement of liquid and material levels. The documentation includes:
Related issue (if applicable): None
Pull request in esphome with YAML changes (if applicable):