Serial multiplexed display #4880
Conversation
WalkthroughA new documentation page for the Changes
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
components/display/images/serial_shift_register.jpgis excluded by!**/*.jpg
📒 Files selected for processing (2)
components/display/serial_multiplexed_display.rst(1 hunks)components/index.rst(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**: - Do not generate or add any sequence diagrams
components/index.rstcomponents/display/serial_multiplexed_display.rst
🪛 GitHub Actions: Lint
components/display/serial_multiplexed_display.rst
[error] 1-1: Sphinx build error: File '/home/runner/work/esphome-docs/esphome-docs/images/serial_shift_register.jpg' for seo tag does not exist.
🔇 Additional comments (1)
components/index.rst (1)
750-750: Add Serial Multiplexed Displays entry
The new entry correctly follows the existing.. imgtable::pattern and alphabetical order. Please verify that the image fileserial_multiplexed_display.jpgexists in theimages/directory and that the path in this index matches the actual file location.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Is this rebased correctly now? Kinda new to git |
jesserockz
force-pushed
the
serial_multiplexed_display
branch
from
d7ec282 to
dfe2c27
Compare
|
Now I have rebased it and it only contains your changes |
|
Should be good now |
Description:
The serial_shift_register display platform allows you to use (for now) two different kinds of serial shift registers to drive segment displays with ESPHome.
Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.