Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of Boards.txt & variants - Adding CYObot board - 3rd party board #10947

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update of Boards.txt & variants - Adding CYObot board - 3rd party board #10947

wants to merge 3 commits into from
+318 −28

Conversation

mhpham23
Copy link

@mhpham23 mhpham23 commented Feb 6, 2025

  1. Adding Pin Header file for CYObot to variants folder
  2. Add CYObot config to boards.txt

I have tested my PR with CYObot v2 board with Arduino-ESP32 core v3.1.1

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. [ x ] Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. [x ] Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. [ x] Please update relevant Documentation if applicable
  4. [x ] Please check Contributing guide
  5. [x ] Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Please describe your proposed Pull Request and it's impact.

No impact

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@mhpham23
Adding CYObot board - 3rd party board
38d1fa0 
1. Adding Pin Header file for CYObot to variants folder
2. Add CYObot config to boards.txt
@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Adding CYObot board - 3rd party board":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello mhpham23, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5dab61d

@mhpham23
feat(cyobot): adding cyobot_v2_esp32s3 board
0298d67 
Change comments in pin header file for cyobot board
@P-R-O-C-H-Y
Copy link
Member

Hi @mhpham23,
please as this is a new board from this manufacturer, move it to the end of the boards.txt file. Thanks

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Feb 10, 2025
View reviewed changes
boards.txt Outdated
cyobot_esp32s3.build.target=cyobot_esp32s3
cyobot_esp32s3.build.mcu=cyobot_esp32s3
cyobot_esp32s3.build.core=esp32
cyobot_esp32s3.build.variant=cyobot_esp32s3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variant name does not match the variant folder.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Status: Awaiting Response awaiting a response from the author labels Feb 10, 2025
@mhpham23
fix(cyobot_v2_esp32s3): fix variant name
5dab61d 
fix variant name for cyobot board
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Status: Awaiting Response awaiting a response from the author Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhpham23 @CLAassistant @P-R-O-C-H-Y