-
Notifications
You must be signed in to change notification settings - Fork 7.6k
HTTPUpdate: Support HTTP 204 #11408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
HTTPUpdate: Support HTTP 204 #11408
Conversation
HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.
👋 Hello sidwarkd, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 43s ⏱️ Results for commit 805905d. ♻️ This comment has been updated with latest results. |
Description of Change
HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.
Tests scenarios
Change is hardware independent and relies on the HTTP return code. Will work on all supported hardware. Tested on Arduino-esp32 core v3.2.0 with ESP32 Devkit C board.