-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: Update BSPs for using button v4 (only LVGL port changes) #500
base: master
Are you sure you want to change the base?
Conversation
Test Results 17 files 17 suites 5m 52s ⏱️ Results for commit 96e5b85. ♻️ This comment has been updated with latest results. |
caf1058
to
39d97c8
Compare
a0f4228
to
232b4a8
Compare
@tore-espressif PTAL |
3d1f29f
to
d3e75e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav esp_lvgl_port LGTM.
I don't have any of these boards now to test...
Strictly speaking, bump of major version of public component is a breaking change -> we should bump major versions of the BSPs too...
However, looking at the button v4 changes, there are only 2:
- Button creation -> this is handled by BSP
- Register/unregistering of button callback -> this will require users to change their code, if they use these functions
I am not sure, if there are real breaking changes:
|
And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs) |
I'd prefer supporting only one (the latest) version |
OK, should I increase major version of affected BSPs? |
d3e75e7
to
96e5b85
Compare
ESP-BSP Pull Request checklist
Change description
Closes #494