Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: Update BSPs for using button v4 (only LVGL port changes) #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Feb 3, 2025

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • Updated LVGL port for using it with button component v4

Closes #494

Copy link

github-actions bot commented Feb 3, 2025

Test Results

 17 files  17 suites   5m 52s ⏱️
 68 tests 24 ✅  44 💤 0 ❌
408 runs  24 ✅ 384 💤 0 ❌

Results for commit 96e5b85.

♻️ This comment has been updated with latest results.

@espzav espzav force-pushed the feat/lvgl_port_button_v4 branch 3 times, most recently from caf1058 to 39d97c8 Compare February 3, 2025 13:53
@espzav espzav force-pushed the feat/lvgl_port_button_v4 branch 2 times, most recently from a0f4228 to 232b4a8 Compare February 4, 2025 13:00
@espzav espzav requested a review from tore-espressif February 4, 2025 14:30
@espzav
Copy link
Collaborator Author

espzav commented Feb 4, 2025

@tore-espressif PTAL

@espzav espzav force-pushed the feat/lvgl_port_button_v4 branch 2 times, most recently from 3d1f29f to d3e75e7 Compare February 6, 2025 13:27
@tore-espressif tore-espressif added this to the esp_lvgl_port 2.5.0 milestone Feb 10, 2025
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav esp_lvgl_port LGTM.

I don't have any of these boards now to test...

Strictly speaking, bump of major version of public component is a breaking change -> we should bump major versions of the BSPs too...
However, looking at the button v4 changes, there are only 2:

  • Button creation -> this is handled by BSP
  • Register/unregistering of button callback -> this will require users to change their code, if they use these functions

@espzav
Copy link
Collaborator Author

espzav commented Feb 11, 2025

However, looking at the button v4 changes, there are only 2:

I am not sure, if there are real breaking changes:

  1. When you are using button v3 with LVGL port --> No breaking changes
  2. When you change from v3 to v4 button with LVGL port --> You must make changes
  3. In BSPs, there is everything handled inside or in examples --> No breaking changes

@espzav
Copy link
Collaborator Author

espzav commented Feb 11, 2025

And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)

@tore-espressif
Copy link
Collaborator

And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)

I'd prefer supporting only one (the latest) version

@espzav
Copy link
Collaborator Author

espzav commented Feb 12, 2025

I'd prefer supporting only one (the latest) version

OK, should I increase major version of affected BSPs?

@espzav espzav removed this from the esp_lvgl_port 2.5.0 milestone Feb 13, 2025
@espzav espzav force-pushed the feat/lvgl_port_button_v4 branch from d3e75e7 to 96e5b85 Compare February 17, 2025 13:32
@espzav espzav changed the title feat(lvgl_port): Update LVGL port for using button v4 (breaking change!) feat(lvgl_port): Update BSPs for using button v4 (only LVGL port changes) Feb 17, 2025
@espzav espzav changed the title feat(lvgl_port): Update BSPs for using button v4 (only LVGL port changes) bsp: Update BSPs for using button v4 (only LVGL port changes) Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp_lvgl_port broken by espressif/button v4.0.0 dependency (BSP-628)
3 participants