bsp(esp32_p4_function_ev_board): Add deinit/remove/delete functions for display (BSP-598) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files 17 suites 5m 53s ⏱️ Results for commit edb30f2. ♻️ This comment has been updated with latest results. |
|
hi, have you test for avoid tear in direct mode? |
espzav
force-pushed
the
feat/bsp_deinit_display
branch
from
a6bc5a2 to
8713649
Compare
Now, I tested it. It is working same. |
|
@tore-espressif PTAL |
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4_function_ev_board.h
Outdated
Show resolved
Hide resolved
espzav
force-pushed
the
feat/bsp_deinit_display
branch
3 times, most recently
from
cc374a0 to
9d35694
Compare
tore-espressif
approved these changes
Feb 20, 2025
…or display and touch.
espzav
force-pushed
the
feat/bsp_deinit_display
branch
from
9d35694 to
edb30f2
Compare
Thank you for review. I checked leaks and there are only lazy inits now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description