Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codeQL code scanning analysis in CI/CD #140

Merged

Conversation

cyrillay
Copy link
Contributor

Add a code vulnerability analysis to step up the security of the repository. This also makes a step towards fitting DINUM's security guidelines.

This tool is nicely integrated with github, and a UI is available on Security tab>Code Scanning. In the screenshot below, I tested it on my branch.

https://github.com/etalab-ia/albert-api/issues#workspaces/674305a48a105f001711f8e4/epics/Z2lkOi8vcmFwdG9yL1plbmh1YkVwaWMvMjIwMzAy?assigneeIds=Z2lkOi8vcmFwdG9yL1plbmh1YlVzZXIvMTk1NTk3Ng

image

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cyrillay cyrillay force-pushed the feat(ci-cd)/add-codeql-vulnerability-analysis-in-ci-cd branch from f4c4694 to 70df8fb Compare January 10, 2025 09:21
@cyrillay cyrillay self-assigned this Jan 10, 2025
@cyrillay cyrillay requested a review from leoguillaume January 10, 2025 09:23
@moscaale moscaale self-requested a review January 10, 2025 09:33
@moscaale
Copy link

I think we should run this job before merging on main ? Like running it every time we are updating the Pull Request ?

@cyrillay
Copy link
Contributor Author

I think we should run this job before merging on main ? Like running it every time we are updating the Pull Request ?

Yes, that's a good point, it should run for every pull request, not only when pushed to main. I modify

@cyrillay cyrillay force-pushed the feat(ci-cd)/add-codeql-vulnerability-analysis-in-ci-cd branch from f9ad1c8 to f8d03f7 Compare January 10, 2025 09:47
@leoguillaume
Copy link
Contributor

LGTM

@leoguillaume leoguillaume merged commit e439024 into main Jan 10, 2025
2 checks passed
@cyrillay cyrillay deleted the feat(ci-cd)/add-codeql-vulnerability-analysis-in-ci-cd branch January 10, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants