Fix: Debug du cache et mise en place d'un TTL de 30 minutes #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArtixJP
commented
Jan 22, 2025
ArtixJP
commented
- Correction du fonctionnement du cache pour éviter les erreurs de récupération des données et leur non mise à jour.
- Ajout d'une expiration automatique des données mises en cache (TTL fixé à 30 minutes).
- Correction du fonctionnement du cache pour éviter les erreurs de récupération des données et leur non mise à jour. - Ajout d'une expiration automatique des données mises en cache (TTL fixé à 30 minutes).
ui/config.py
Outdated
| @@ -7,6 +7,7 @@ | |||
| RERANK_MODEL_TYPE = "text-classification" | |||
| INTERNET_COLLECTION_DISPLAY_ID = "internet" | |||
| PRIVATE_COLLECTION_TYPE = "private" | |||
| DUREE_CACHE_EN_SECONDES = 1800 # 30 minutes | |||
There was a problem hiding this comment.
Pas de francais dans le code
| @@ -84,7 +89,9 @@ def get_models(api_key: str) -> tuple[str, str, str]: | |||
| return language_models, embeddings_models, audio_models, rerank_models | |||
|
|
|||
|
|
|||
| @st.cache_data(show_spinner="Retrieving data...") | |||
| # Collections | |||
|
|
|||
There was a problem hiding this comment.
espace en trop, il faut appliqué le linter
ui/utils.py
Outdated
| @@ -170,11 +135,15 @@ def upload_file(api_key: str, file, collection_id: str) -> None: | |||
|
|
|||
| if response.status_code == 201: | |||
| st.toast("Upload succeed", icon="✅") | |||
| #clear cache | |||
| get_collections.clear(api_key) #since the number of documents in the collection has changed | |||
There was a problem hiding this comment.
application du linter
ui/utils.py
Outdated
| else: | ||
| st.toast("Upload failed", icon="❌") | ||
|
|
||
|
|
||
| @st.cache_data(show_spinner="Retrieving data...") | ||
| #ttl = x, persistence de x secondes |
There was a problem hiding this comment.
pas de code commenter dans le code
- Fixed cache retrieval issues to prevent outdated or incorrect data. - Implemented automatic cache refresh with a 30-minute time-to-live (TTL).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.