Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Fix runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type #18893 #18951

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ktalg
Copy link
Contributor

@ktalg ktalg commented Nov 26, 2024

@k8s-ci-robot
Copy link

Hi @ktalg. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (2abb334) to head (438f9fa).
Report is 2 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18951      +/-   ##
==========================================
+ Coverage   68.66%   68.71%   +0.04%     
==========================================
  Files         420      420              
  Lines       35563    35563              
==========================================
+ Hits        24420    24437      +17     
+ Misses       9711     9700      -11     
+ Partials     1432     1426       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abb334...438f9fa. Read the comment docs.

CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Nov 26, 2024

Also please signoff the commit. Read https://github.com/etcd-io/etcd/pull/18951/checks?check_run_id=33536510903

@ktalg ktalg force-pushed the main branch 2 times, most recently from 9268acd to 3337bec Compare November 26, 2024 13:54
…h a Context implemented by an uncomparable type etcd-io#18893

Signed-off-by: KT <[email protected]>
@ahrtr
Copy link
Member

ahrtr commented Nov 27, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ktalg

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, ktalg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 9974928 into etcd-io:main Nov 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants