Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling for markdown linting #19425

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Zanda256
Copy link

@Zanda256 Zanda256 commented Feb 16, 2025

With this pull request, we add a bash script to run linting check on modified or newly added markdown files. We then add a makefile target to run the script using make.

Partially resolves #18059

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zanda256
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @Zanda256. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The script runs markdown lint on newly created markdown files, or modified lines in old files.

Signed-off-by: Sekiranda Hamza [email protected]
Signed-off-by: Sekiranda <[email protected]>
@Zanda256 Zanda256 force-pushed the tooling_markdown_lint branch from f65e917 to ea90940 Compare February 16, 2025 01:40
@joshjms
Copy link
Contributor

joshjms commented Feb 17, 2025

#18059

@Zanda256 Zanda256 marked this pull request as ready for review February 17, 2025 19:41
@Zanda256 Zanda256 marked this pull request as draft February 17, 2025 19:53
@Zanda256 Zanda256 marked this pull request as ready for review February 17, 2025 23:07
@ivanvc ivanvc self-requested a review February 18, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Find a replacement for marker (markdown linter)
3 participants