Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Update golang toolchain to 1.23.6 #19430

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[3.5] Update golang toolchain to 1.23.6 #19430

merged 1 commit into from
Feb 18, 2025

Conversation

joshjms
Copy link
Contributor

@joshjms joshjms commented Feb 17, 2025 •
edited
Loading

  • Update .go-version to 1.23.6
  • Update Go version directives in go.mod files to 1.23.0
  • Update toolchain to 1.23.6

Subtask of #19417

@k8s-ci-robot
Copy link

Hi @joshjms. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test area/tooling github_actions Pull requests that update GitHub Actions code size/XXL labels Feb 17, 2025
@joshjms joshjms closed this Feb 17, 2025
@joshjms joshjms reopened this Feb 17, 2025
@joshjms joshjms changed the base branch from main to release-3.5 February 17, 2025 06:08
@joshjms joshjms force-pushed the bump-go-v1.23.6-release-3.5 branch from 5536af0 to f85ffdb Compare February 17, 2025 06:09
@joshjms joshjms force-pushed the bump-go-v1.23.6-release-3.5 branch 2 times, most recently from d60afdc to 98d0dfe Compare February 17, 2025 06:32
ahrtr
ahrtr reviewed Feb 17, 2025
View reviewed changes
api/go.mod Outdated
@@ -1,8 +1,8 @@
module go.etcd.io/etcd/api/v3

go 1.22
go 1.23.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep using 1.23 instead of 1.23.0? If the suffix ".0" is automatically added by go mod tidy, then it's OK to keep it.

@ahrtr ahrtr mentioned this pull request Feb 17, 2025
Merged
@ahrtr
Copy link
Member

ahrtr commented Feb 17, 2025

please squash the commit

@joshjms
bump go to v1.23.6
a2f96f0 
Signed-off-by: joshjms <[email protected]>

change go directive to 1.23

Signed-off-by: joshjms <[email protected]>
@joshjms joshjms force-pushed the bump-go-v1.23.6-release-3.5 branch from ecc9e6f to a2f96f0 Compare February 17, 2025 20:04
@joshjms
Copy link
Contributor Author

joshjms commented Feb 17, 2025

i squashed the commit

@ivanvc
Copy link
Member

ivanvc commented Feb 18, 2025

/ok-to-test

@ivanvc ivanvc mentioned this pull request Feb 18, 2025
Open
16 tasks
ahrtr
ahrtr approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

ivanvc
ivanvc approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @joshjms.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit fa7a22a into etcd-io:release-3.5 Feb 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved area/clientv3 area/documentation area/etcdctl area/etcdutl area/observability area/performance area/testing area/tooling github_actions Pull requests that update GitHub Actions code ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshjms @k8s-ci-robot @ahrtr @ivanvc