Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload/download: added safe for URLs in jinja templates #22

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

jpdorsch
Copy link
Collaborator

The URLs were not encoded correctly (for instance quotes, &, and others).
Using safe filter for jinja templates (reference) to avoid auto-escaping of special characters.

@jpdorsch jpdorsch self-assigned this Feb 27, 2025
@jpdorsch jpdorsch requested review from theely and ekouts and removed request for theely February 27, 2025 17:11
ekouts
ekouts previously approved these changes Feb 28, 2025
Copy link
Collaborator

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpdorsch jpdorsch merged commit de9eb0a into master Feb 28, 2025
2 checks passed
@jpdorsch jpdorsch deleted the RESTAPI-1441-fix-issue-download-s3 branch February 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants