Add release and release_all methods
#270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
release-tx-rx
branch
from
f938b38 to
71630da
Compare
It used to be deprecated but it's crap code and the way it's written makes the `release()` stuff very hard to get right.
Not that I run clippy very much but stil...
jamwaffles
force-pushed
the
release-tx-rx
branch
3 times, most recently
from
86be784 to
9a0c07c
Compare
jamwaffles
force-pushed
the
release-tx-rx
branch
from
9a0c07c to
c267a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Tests for bothvery, very difficult to do replay tests with the current harness.releaseandrelease_all