Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Fix mutually exclusive flags used by cannon executor #15004

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Mar 24, 2025

Fix the challenger's invocation of cannon for the interop case.

@Inphi Inphi requested a review from ajsutton March 24, 2025 05:03
@Inphi Inphi requested review from a team as code owners March 24, 2025 05:03
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (059849d) to head (bc19081).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15004       +/-   ##
============================================
+ Coverage    46.51%   66.40%   +19.88%     
============================================
  Files         1149       61     -1088     
  Lines        98727     4813    -93914     
============================================
- Hits         45927     3196    -42731     
+ Misses       49497     1439    -48058     
+ Partials      3303      178     -3125     
Flag Coverage Δ
cannon-go-tests-32 62.08% <ø> (-2.00%) ⬇️
cannon-go-tests-64 57.13% <ø> (-1.64%) ⬇️
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1097 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Inphi Inphi added this pull request to the merge queue Mar 25, 2025
Merged via the queue into develop with commit 7e6825b Mar 25, 2025
50 checks passed
@Inphi Inphi deleted the inphi/chal-exec-flags branch March 25, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants