chore: Simplify op-deployer scripts: DeploySuperchain [1/N] #15014
+521
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An investigation PR focused on reducing the complexity of deploy scripts, taking
DeploySuperchain
as a test subject. Instead of modifying the original script,DeploySuperchain2
has been introduced to allow for step-by-step migration and side-by-side comparison.BaseDeploy
abstract contract that isolates common deployment logic. This contract also allows us to test the deployment scripts themselves (see code comments)Relates to #14976
Notes
DeploySuperchain
) has partial public functions besides the main entrypoint (and partial assertion functions). To impose a cleaner interface, I propose no such partial functions - instead, separate deployment script contracts should be defined (could be in the same file), each with only one public function (run
). This way, the convention runs all the way through the codebase.