Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: superchain address registry #703

Merged
merged 7 commits into from
Mar 2, 2025
Merged

refactor: superchain address registry #703

merged 7 commits into from
Mar 2, 2025

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Mar 2, 2025

Now, the only thing MultisigTask needs to know about an address registry is its address, so it can be filtered out in the _isValidAction method

  • Renames AddressRegistry to SuperchainAddressRegistry
  • Deduplicates the two corresponding test files into a single test file
  • Cleaner addresses.toml format, and key names now match the network short names
  • Removes unused functions from SuperchainAddressRegistry
  • Simplifies code and data structures in SuperchainAddressRegistry
  • Organizes functions in SuperchainAddressRegistry

cc @blmalone @AmadiMichael @ElliotFriedman @prat-gpt

@mds1 mds1 requested review from blmalone and AmadiMichael March 2, 2025 16:08
@mds1 mds1 requested review from a team as code owners March 2, 2025 16:08
blmalone
blmalone previously approved these changes Mar 2, 2025
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mds1 mds1 added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit 4b6812a Mar 2, 2025
17 checks passed
@mds1 mds1 deleted the refactor/addr-registry branch March 2, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants