feat(specs): verify intermidiate block state in blockchain test #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
reviewed
Jan 14, 2025
winsvega
force-pushed
the
interstate
branch
2 times, most recently
from
cc385d3 to
4f2e55b
Compare
8 tasks
|
add a unit test to |
marioevz
reviewed
Jan 16, 2025
| @@ -570,7 +577,12 @@ def make_fixture( | |||
| ), | |||
| ) | |||
|
|
|||
| self.verify_post_state(t8n, alloc) | |||
| if block.expected_post_state: | |||
There was a problem hiding this comment.
We could try to move this into the generate_block_data so it's verified for make_fixture and make_hive_fixture too.
There was a problem hiding this comment.
this violates the logic. because function states generate_block_data and it will be implicit that it also verifies the post state
marioevz
approved these changes
Jan 17, 2025
marioevz
changed the title
|
Once #1085 is merged we can rebase and CI should be green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Allow verification of individual block states in blockchain test
🔗 Related Issues
#1033
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.