feat(tests): Additional EIP-7702 cases: #1400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
commented
Apr 4, 2025
|
|
||
| @pytest.mark.valid_from("Prague") | ||
| @pytest.mark.parametrize("chain_id", [0, 1]) | ||
| def test_chained_delegation_stops_after_one_hop( |
There was a problem hiding this comment.
I believe this is the same test case as pointer_to_pointer state test, though the state test does not have a control. I think that's fine. Should I remove this or merge them somehow?
edit: The OOG comment in the docstring throws me off a bit in the pointer_to_pointer test. Not sure if it expects the loop contract to trigger and lead to OOG or test that it doesn't trigger, in which case isn't that testing a no-op?
fselmo
force-pushed
the
eip7702-test-additions
branch
2 times, most recently
from
c3fb63f to
c052467
Compare
33 tasks
fselmo
force-pushed
the
eip7702-test-additions
branch
2 times, most recently
from
0e508c3 to
7461fcf
Compare
fselmo
added
scope:tests
fselmo
changed the title
fselmo
changed the title
fselmo
force-pushed
the
eip7702-test-additions
branch
2 times, most recently
from
ceea2e4 to
7c80f36
Compare
- Test a chained delegation stops after one hop (does not delegate to and address that is itself delegated). - Test delegation to an initially-empty address that later has bytecode deployed to it, making sure delegation to the newly deployed code succeeds.
fselmo
force-pushed
the
eip7702-test-additions
branch
from
7c80f36 to
d433502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Test a chained delegation stops after one hop (does not delegate to an address that is itself delegated)Test delegation to an initially-empty address that later has bytecode deployed to it. This tests before and after and makes sure once code is present, it successfully delegates to the deployed code.🔗 Related Issues
#1299
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.