Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use solc-select for tox #604

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jun 7, 2024

🗒️ Description

Adds a step toward deprecating the requirement of solc for EEST (using solc-select instead).

Tox passes after merging this into my origin main, check recent commits:
https://github.com/spencer-tb/execution-spec-tests

I personally have not used an "installed solc" for the past 3 months, and instead used solc-select.
Due to the latter I've kept these changes trailing in my local repo for running tox.

🔗 Related Issues

#461 - planning to split the latter into smaller PRs, this PR being one of them.

Future PRs will include the deprecation of solc completely in within EEST in favor of solc-select.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb spencer-tb requested a review from marioevz June 7, 2024 05:04
@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:feat type: Feature labels Jun 7, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice, IMO the less things we have to update directly in the CI workflow files, the better.

@marioevz marioevz merged commit 9786d5a into ethereum:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants