Skip to content

Implement EIP 4361 #32041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implement EIP 4361 #32041

wants to merge 6 commits into from

Conversation

scanhex12
Copy link

@scanhex12 scanhex12 commented Jun 15, 2025

Implementation of #24132
Added handler for SIWE in CLEF
Example of usage:

curl -X POST --data '{"id": 0, "jsonrpc": "2.0", "method": "account_approveSIWE", "params": [{ "domain": "login.xyz", "address": "0x9D85ca56217D2bb651b00f15e694EB7E713637D4", "statement": "Sign-In With Ethereum Example Statement", "uri": "https://login.xyz", "version": "1", "nonce": "bTyXgcQxn2htgkjJn", "issuedAt": "2022-01-27T17:09:38.578Z", "chainId": 1, "expirationTime": "2100-01-07T14:31:43.952Z" }, "0xdc35c7f8ba2720df052e0092556456127f00f7707eaa8e3bbff7e56774e7f2e05a093cfc9e02964c33d86e8e066e221b7d153d27e5a2e97ccd5ca7d3f2ce06cb1b"]}' http://localhost:8550 -H "Content-Type: application/json"

{"jsonrpc":"2.0","id":0,"result":true}

@scanhex12 scanhex12 requested a review from rjl493456442 as a code owner June 15, 2025 18:54
Domain: "foo",
}
_, err := api.ApproveSIWE(ctx, req, "some_inc_signature")
expectDeny("siwe", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should also have a passing test

@fjl
Copy link
Contributor

fjl commented Jun 17, 2025

Sorry, we do not have the capacity to review PRs to clef at the moment. It's also unclear to us how this method would be called. Would you run clef on your machine alongside the browser, and have websites talk to the API? Please provide some use case information so we can better judge this proposed API addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants