core: add Indexer interface and index server logic (WIP) #32292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
force-pushed
the
indexer-interface
branch
from
c68b99a to
9601a6a
Compare
zsfelfoldi
force-pushed
the
indexer-interface
branch
from
356e5ab to
27d4a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new indexer interface (
core.Indexer) that greatly simplifies the implementation of chain indexers. The serving mechanism is integrated intocore.BlockChainwhich makes it possible to guarantee that a chain index always stays in sync with the canonical chain. New heads are always delivered before chain events are sent, ensuring that any consumer of these events can also rely on the chain index being in sync. Required historic chain sections are delivered asynchronously on demand. It is always guaranteed that any delivered blocks(including historic ones) are part of the canonical chain ending with the latest delivered/reverted head.Note that the interface currently only delivers headers and receipts which are required by the log indexer. If we want to make it more general purpose then we should somehow make it configurable (delivering full blocks and receipts could be optional).
Also note that the PR also adds two new features to
core.BlockChainthat I wanted to add for a very long time:GetReceipts(hash common.Hash, number uint64) types.Receiptswhich saves an unnecessary hash -> number lookup (an expensive random db read).GetCanonicalHashes(numbers []uint64) ([]common.Hash, error)which reads multiple canonical hashes under thechainMumutex lock, guaranteeing that they are consistent with each other.