Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/hiveview: multiple UI improvements #1227

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Jan 23, 2025

Some new features:

General:

  • Allow passing --limit to the hiveview --listings command. So that we can decide how many we want to index. Still kept 200 as default.
  • Added client versions to the hiveview --listings output, so that we can show them on the index page.

Index:

  • Summary on top, that has a box for each simulator/client pair that was run. Sortable by name,coverage or time.
  • Clicking on the box brings the user to the table view, where all the past executed tests can be seen (filtered by sim/client pairs)
  • Added a diff column, that shows a counter of + or - passed
    tests, compared to the previous test run (from the same simulator + client pairs)
  • Generally adding a bit more colors and smaller design adjustments
  • Show the specific client version in the table
  • Added some keyboard shortcuts

Suite page:

  • Allow rendering html within the test description. Used a lot by the ethereum/eest simulators, where they show how to reproduce a specific test.
  • Show total passed/failed tests stats on the top right and add colors to it (green -> passed, red -> failed)

Viewer:

  • Add log syntax highlighting using prism

localhost_8001_ (2)

@skylenet skylenet changed the title hiveview: add summary boxes and improve table view cmd/hiveview: add summary boxes and improve table view Jan 30, 2025
@skylenet skylenet requested a review from fjl January 31, 2025 15:31
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks absolutely amazing, thanks for this!

cc @fjl on final check for this since he is the owner of all of these files :)

@skylenet skylenet changed the title cmd/hiveview: add summary boxes and improve table view cmd/hiveview: multiple UI improvements Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants