Load infura url manually #149
Conversation
|
@kclowes Let me know if this is a good solution that you had in mind. If so, i'll merge and cut a new release today |
| @@ -2,7 +2,8 @@ | |||
| from urllib import parse | |||
|
|
|||
| from eth_utils import to_bytes | |||
| from web3.auto.infura import w3 | |||
| from web3 import Web3 | |||
| from web3.providers.auto import load_provider_from_uri | |||
|
|
|||
| from ethpm.backends.base import BaseURIBackend | |||
| from ethpm.constants import INFURA_API_KEY | |||
There was a problem hiding this comment.
Can we get a tracking issue for this? We should probably plan to be rid of it within a month or two at the very most.
There was a problem hiding this comment.
Just in terms of removing the INFURA_API_KEY from constants.py and requiring users to provide their own?
There was a problem hiding this comment.
Removing it from constants and coming up with the mechanism that 1) doesn't require users to use infura since it effectively leaks privacy information and we shouldn't have a hard dependency on a centralized solution but 2) still preserves as much ease of usability as possible.
I recognize moving away from infura probably goes opposite of conversations you and I had about it being a fine solution, but with this stuff moving into production I think it's now time to address that particular piece of debt.
This probably really means leaving the ethpm library such that it require more manual configuration and addressing the usability component in the web3.py codebase.
|
I think this should work @njgheorghita. Thank you! |
What was wrong?
#148
How was it fixed?
w3instance in favor of manually generatedw3endpoint using infura tokenCute Animal Picture