feat: lazy timer commands #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, it was not possible to lazily declare an fb_timers entry that utilized a node attribute inside the command. After this commit, specifying a Proc for `command` or entries in `commands` will cause fb_timers to evaluate the proc when rendering the service template.
kcronin
approved these changes
Nov 11, 2024
ericnorris
added a commit
that referenced
this pull request
Nov 11, 2024
Per @kornface13, this is no longer necessary - reverting so I can pull in #28. This reverts commit ec07a0e, reversing changes made to b774201.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of facebook#242.