Fix nfc #126
Open
Fix nfc #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valuesets were never being downloadad, making rule validation fail
The reference to the NFCHelper was being lost, making the NFC read never resolve. The code has been moved to the ViewController, which has a strong reference. I also improved the Text record type parsing, taking into account the payload locale and encoding flags, accepting only text record that begin with HC1. This allows for tags with multiple records and only returning the one containing a DCC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to the NFCHelper was being lost, making the NFC read never resolve. The code has been moved to the ViewController, which has a strong reference. I also improved the Text record type parsing, taking into account the payload locale and encoding flags, accepting only text record that begin with HC1. This allows for tags with multiple records and only returning the one containing a DCC.