Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace window label string concatenation with interpolation #324

Closed
wants to merge 1 commit into from
Closed

Replace window label string concatenation with interpolation #324

wants to merge 1 commit into from

Conversation

itsrenderman
Copy link
Contributor

More aesthetically pleasing and easier to read over the former concatenation

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

More aesthetically pleasing and easier to read over the former concatenation
@autonordev
Copy link
Collaborator

Thanks for the pull-request. While it is more aesthetically pleasing to use interpolation, the Cmdr codebase is full of legacy code that works just fine (including concatenation and non-generalised iteration on dictionaries). Accordingly, commits which exclusively replace legacy with non-legacy features aren't ideal. If you're working on a contribution and see some related legacy code, changing it to modern features is OK though. 'Aesthetically pleasing' is itself not a very compelling reason to accept a change, even a plain simple one like this, given that the current legacy code is easily readable.

@autonordev autonordev closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants