Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rand Command to Use Random Class #331

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

wilyt1
Copy link
Collaborator

@wilyt1 wilyt1 commented Jul 13, 2024

Fixes #329 by using Random.new() instance instead of math.random(). Also updates function parameter names to match command arguments and reduce ambiguity.

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

Copy link
Collaborator

@autonordev autonordev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please carefully test to make sure this works as expected (if you haven't already).

@wilyt1 wilyt1 merged commit 442f98f into evaera:master Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rand to use Random class
2 participants