Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Window.lua #332

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Update Window.lua #332

merged 2 commits into from
Aug 24, 2024

Conversation

lucasnielsen
Copy link
Contributor

This simple addition fixes an issue that causes the keyboard to completely break on mobile devices. Streamable link

The script before would cause :CaptureFocus() everytime the TextBox would lose focus, creating an infinite loop of the keyboard opening and closing extremely quickly (as shown in the video link above).

My fix to this is adding a check if the user is on mobile or not. If they are on mobile, it will stop Entry.TextBox:CaptureFocus() from being ran.

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

lucasnielsen and others added 2 commits August 3, 2024 16:44
Fixes an issue that causes the keyboard to completely break on certain mobile devices.
Copy link
Collaborator

@wilyt1 wilyt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

@wilyt1 wilyt1 merged commit fce0f0b into evaera:master Aug 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants