Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abridge entry when PlaceName is empty #338

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Abridge entry when PlaceName is empty #338

merged 1 commit into from
Sep 4, 2024

Conversation

wilyt1
Copy link
Collaborator

@wilyt1 wilyt1 commented Aug 29, 2024

Closes #336. Checks if PlaceName exists and is not an empty string. Replaces string concatenation with string interpolation.

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

autonordev
autonordev approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@autonordev autonordev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but LGTM

@wilyt1 wilyt1 merged commit 0cac041 into evaera:master Sep 4, 2024
1 check passed
@wilyt1 wilyt1 deleted the abridge-entry-empty-placename branch September 4, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autonordev autonordev autonordev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abridge entry if PlaceName is empty string
2 participants
@wilyt1 @autonordev