Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): add bench for matrix transposition #526

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

eholum
Copy link
Contributor

@eholum eholum commented Feb 9, 2024

Putting this in as a pre-requisite to #524.

Would like to get a baseline for square matrix transposes before adding support for non-square matrices.

@samueltardieu
Copy link
Collaborator

Nitpick: could you use "feat(bench): add bench for matrix transposition" in the title and I'll merge this? (colon and lower-case to add)

@eholum eholum changed the title feat(bench) Add bench for matrix transposition feat(bench): add bench for matrix transposition Feb 9, 2024
@eholum
Copy link
Contributor Author

eholum commented Feb 9, 2024

Nitpick: could you use "feat(bench): add bench for matrix transposition" in the title and I'll merge this? (colon and lower-case to add)

Done! Sorry, will also fix the format errors...

@samueltardieu
Copy link
Collaborator

Nitpick: could you use "feat(bench): add bench for matrix transposition" in the title and I'll merge this? (colon and lower-case to add)

Done! Sorry, will also fix the format errors...

I meant in the commit message. As soon as this is done I'll merge it, thanks again.

Copy link

codspeed-hq bot commented Feb 9, 2024

CodSpeed Performance Report

Merging #526 will not alter performance

Comparing eholum:add-matrix-benchmark (cd9a544) with main (6add39b)

Summary

✅ 32 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main eholum:add-matrix-benchmark Change
🆕 transpose N/A 159.8 µs N/A

@eholum eholum force-pushed the add-matrix-benchmark branch from a2222b9 to cd9a544 Compare February 9, 2024 16:49
@eholum
Copy link
Contributor Author

eholum commented Feb 9, 2024

I meant in the commit message.

Whoops, sorry! NOW it's fixed. I believe I also addressed the fmt/clippy errors.

@samueltardieu samueltardieu added this pull request to the merge queue Feb 9, 2024
Merged via the queue into evenfurther:main with commit 034a85e Feb 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants