Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add priority to clippy lints for lint_groups_priority #527

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

eholum
Copy link
Contributor

@eholum eholum commented Feb 10, 2024

They added a lint_groups_priority check last week that caused this failure in CI.

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:53:1
   |
53 | pedantic = "deny"
   | ^^^^^^^^   ------ has an implicit priority of 0
54 | module_name_repetitions = "allow"
   | ----------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `pedantic` to a lower priority
   |
53 | pedantic = { level = "deny", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Adding explicit priorities to the clippy lint rules resolves this check. I think previous CI was passing because of cached clippy versions from before v0.1.78 was released.

Copy link

codspeed-hq bot commented Feb 10, 2024

CodSpeed Performance Report

Merging #527 will not alter performance

Comparing eholum:update-clippy-config (1ba2119) with main (034a85e)

Summary

✅ 33 untouched benchmarks

@samueltardieu samueltardieu added this pull request to the merge queue Feb 11, 2024
@samueltardieu
Copy link
Collaborator

Thanks

Merged via the queue into evenfurther:main with commit 6dbe4de Feb 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants