Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to be merged with MSRV 1.83 #636

Merged
merged 7 commits into from
Mar 2, 2025
Merged

Changes to be merged with MSRV 1.83 #636

merged 7 commits into from
Mar 2, 2025

Conversation

samueltardieu
Copy link
Collaborator

No description provided.

@samueltardieu samueltardieu added the MSRV bump Will be merged later, requires a MSRV bump label Jan 3, 2025
Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #636 will degrade performances by 34.15%

Comparing msrv-1.83 (046a34d) with main (e5c8bfd)

Summary

❌ 3 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
fill-corner_to_corner_idastar 146.1 µs 221.9 µs -34.15%
corner_to_corner_dijkstra 1.5 ms 1.8 ms -17.67%
no_path_dijkstra 1.4 ms 1.7 ms -18.34%

@samueltardieu samueltardieu force-pushed the msrv-1.83 branch 2 times, most recently from cc60408 to f4b36e4 Compare January 15, 2025 12:42
@samueltardieu samueltardieu force-pushed the msrv-1.83 branch 2 times, most recently from 70126ef to 0d35cdd Compare January 25, 2025 12:19
@samueltardieu samueltardieu force-pushed the msrv-1.83 branch 8 times, most recently from fb22ad6 to 99d43c4 Compare February 16, 2025 21:25
@samueltardieu samueltardieu added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit bf7c3ab Mar 2, 2025
13 checks passed
@samueltardieu samueltardieu deleted the msrv-1.83 branch March 2, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSRV bump Will be merged later, requires a MSRV bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant