Merge branch 'fix/remove-cipher-todo' into main

everest-engineering · Oct 17, 2020 · 056538e · 056538e
2 parents 75766cc + 26dd76a
commit 056538e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/...a/engineering/everest/starterkit/axon/cryptoshredding/encryption/DefaultAesDecrypter.java b/...a/engineering/everest/starterkit/axon/cryptoshredding/encryption/DefaultAesDecrypter.java
@@ -25,7 +25,6 @@ public DefaultAesDecrypter(SecureRandom secureRandom) {
 
     public String decrypt(SecretKey secretKey, byte[] initializationVectorAndCipherText) {
         try {
-            // TODO this doesn't look reentrant
             var cipher = Cipher.getInstance(CIPHER_ALGORITHM);
             cipher.init(DECRYPT_MODE, secretKey, new IvParameterSpec(initializationVectorAndCipherText, 0, INITIALIZATION_VECTOR_LENGTH), secureRandom);
             return new String(cipher.doFinal(initializationVectorAndCipherText, INITIALIZATION_VECTOR_LENGTH, initializationVectorAndCipherText.length - INITIALIZATION_VECTOR_LENGTH));

diff --git a/...a/engineering/everest/starterkit/axon/cryptoshredding/encryption/DefaultAesEncrypter.java b/...a/engineering/everest/starterkit/axon/cryptoshredding/encryption/DefaultAesEncrypter.java
@@ -26,7 +26,6 @@ public DefaultAesEncrypter(SecureRandom secureRandom) {
 
     public byte[] encrypt(SecretKey secretKey, String cleartext) {
         try {
-            // TODO this doesn't look reentrant
             var cipher = Cipher.getInstance(CIPHER_ALGORITHM);
             byte[] initializationVector = createInitializationVector();
             cipher.init(ENCRYPT_MODE, secretKey, new IvParameterSpec(initializationVector), secureRandom);