Applied REFACTORING methods #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e conditional, Rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied REFACTORING methods to the following files:
1. JsonPointerEvaluator.java:
method -> JsonObject()
changed the variable name to a more meaningful name.
2. StringToValueConverter.java:
method -> isDecimalNotation()
introduced variables to decompose the complex expression in the return statement.
method -> stringToNumber()
broke down the complex conditional statements by adding new methods, so that it enhances manageability.
I'm a master's student at Dalhousie University, Halifax, NS, Canada.
I applied these changes, as a part of my assignment.
I will get some bonus points if my pull request gets approved.
So, please review my changes, and if it satisfies you, do accept the PR.
Thank you.