Set up new FFI bindings for libcurl #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
369-libcurl-ffi-integration
branch
from
219a96b to
1540096
Compare
rdw-software
force-pushed
the
369-libcurl-ffi-integration
branch
from
1540096 to
4b981c0
Compare
rdw-software
force-pushed
the
369-libcurl-ffi-integration
branch
3 times, most recently
from
3fd1c42 to
6ffccc8
Compare
The headers are required when building lua-openssl (and libcurl) against the cached OpenSSL libraries. Right now they're not included, which leads CMake to silently fall back to the system-installed version. While that might be convenient, it's really not desirable here. In fact, it's exactly what I'm trying to avoid. The system version could be much older than the embedded one. Although that's of course unlikely, since distro maintainers will want to keep OpenSSL as updated as possible. In that scenario, building libcurl (and lua-openssl) against different versions could cause all sorts of issues.
Due to this minor oversight, the build script moved the generated artifacts and CMake subsequently failed to find them, silently falling back to the incorrect system-provided version. This then lead to libcurl using the wrong headers because CMake "found" them elsewhere, without realizing the versions didn't match or generating any warnings.
rdw-software
force-pushed
the
369-libcurl-ffi-integration
branch
from
6ffccc8 to
3a8e8e7
Compare
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only includes the boilerplate and version info API. Will add some core functionality soon, but separately.